Typo in ReadMe + client_kwargs for OpenAI-compatible APIs in Detector + prompt on Decoder #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot, running the tests to see if the updated prompt still works for OpenAI models |
|
I see there are some test failures here, I think we have to make sure client_kwargs is supported everywhere. |
|
Thanks for the feedback (and for the Invariant: really like it)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import invariant.testing.functionalinstead ofimport invariant.testing.testing.functional as F. But I messed up the table of contents, so probably ReadMe fix should be discarded.Detector()andInvariantString.extract(). It may be useful if people want to use local models through OpenAI-compatible APIAfter the change it was working as intended:
But now the system prompt became similar to Anthropic. Not sure whether I changed what should have been changed.